Update security estimator to take into account method of batching #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irakliyk
reviewed
Feb 1, 2025
Comment on lines
35
to
+36
| // compute max security we can get for a given field size | ||
| let field_size = base_field_bits * options.field_extension().degree(); | ||
| let field_security = field_size - (trace_domain_size * options.blowup_factor()).ilog2(); | ||
| let field_security = base_field_bits * options.field_extension().degree(); |
There was a problem hiding this comment.
This makes conjectured security estimate a bit less conservative, right?
There was a problem hiding this comment.
Indeed, the conjecture implies that the soundness of the protocol is not affected by the domain size or, as far as I can see, the batching used in either the computation of the quotient polynomials or the DEEP polynomial.
Added a couple of tests to check for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the estimator to take into account the method of batching used in computing the DEEP polynomial.
Note also: