Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GKR related code #359

Merged
merged 7 commits into from
Feb 1, 2025
Merged

Remove GKR related code #359

merged 7 commits into from
Feb 1, 2025

Conversation

Al-Kindi-0
Copy link
Contributor

As the integration of LogUp-GKR is on pause for the time being, it makes sense to remove the code related to it from the codebase.
If things change and we go ahead with the integration then there is at least one branch containing the full version of LogUp-GKR namely, the logup-gkr branch.
Putting in draft until some open PRs are merged.

@Al-Kindi-0 Al-Kindi-0 marked this pull request as ready for review January 31, 2025 18:54
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few small comments inline. Once these are addressed, we can merge.

verifier/src/lib.rs Show resolved Hide resolved
prover/src/lib.rs Outdated Show resolved Hide resolved
air/src/proof/ood_frame.rs Outdated Show resolved Hide resolved
air/src/proof/ood_frame.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@irakliyk irakliyk merged commit 2765f6d into facebook:main Feb 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants