Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stark proof serializable deserializable #231

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Stark proof serializable deserializable #231

merged 1 commit into from
Dec 1, 2023

Conversation

hackaugusto
Copy link
Contributor

  • adds size hints to some serializations
  • implement serialization and deserialization traits for StarkProof (using existing code)
  • add blanket implementation for integers and option type

irakliyk
irakliyk approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good!

The only thing I'm not sure about is serializing usize values. These could have different number of bytes on different platforms and so something serialized on one platform may fail to deserialize on the other.

@hackaugusto hackaugusto force-pushed the hacka-stark-proof-serializable-deserializable branch from 8ff2787 to 0e94b7b Compare November 30, 2023 23:29
@hackaugusto
Copy link
Contributor Author

The only thing I'm not sure about is serializing usize values. These could have different number of bytes on different platforms and so something serialized on one platform may fail to deserialize on the other.

good point, removed it.

@hackaugusto hackaugusto force-pushed the hacka-stark-proof-serializable-deserializable branch 2 times, most recently from 144c099 to 562b921 Compare November 30, 2023 23:32
@hackaugusto hackaugusto force-pushed the hacka-stark-proof-serializable-deserializable branch from 562b921 to addca1f Compare November 30, 2023 23:50
@irakliyk irakliyk merged commit a671515 into facebook:main Dec 1, 2023
9 checks passed
@hackaugusto hackaugusto deleted the hacka-stark-proof-serializable-deserializable branch December 1, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irakliyk irakliyk irakliyk approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hackaugusto @irakliyk @facebook-github-bot