Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Starlark: Restart starlark language server" command #84

Open
cjhopman opened this issue Aug 29, 2023 · 1 comment
Open

Add "Starlark: Restart starlark language server" command #84

cjhopman opened this issue Aug 29, 2023 · 1 comment
Labels

Comments

@cjhopman
Copy link
Contributor

The starlark language server isn't super reliable and I need to restart it at times. Needing to restart the entire extension host to get that is kinda inconvenient. rust-analyzer has the nice option of just restarting it's language server as a command, we could do that too.

@cjhopman
Copy link
Contributor Author

I'm not sure how rust-analyzer does this. vscode kinda partially handles the lsp executable interaction, and i know on startup at least it will restart it if it crashes, i wonder if just killing the process is enough to implement this. If it is, maybe we'd want it done differently for starlark vs buck2. i continue to think we should explicitly fork the extension for buck2 rather than needing to make every behavior configurable (and actually there's a lot of things that we want more configurable than they are in the starlark extension today).

@ndmitchell ndmitchell added the lsp label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants