Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -cname-chasing option #85

Closed
wants to merge 1 commit into from

Conversation

aryanpatel3
Copy link
Contributor

Summary: Add a -cname-chasing command-line argument to fbdns. This allows us to control whether CNAME chasing in enabled or not.

Differential Revision: D64804019

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64804019

Summary:

Add a -cname-chasing command-line argument to fbdns. This allows us to control whether CNAME chasing in enabled or not.

Differential Revision: D64804019
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64804019

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 51.21951% with 20 lines in your changes missing coverage. Please review.

Project coverage is 59.24%. Comparing base (86af19b) to head (9f33e7f).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
dnsrocks/fbserver/cnamechasing.go 0.00% 7 Missing ⚠️
dnsrocks/fbserver/server.go 65.00% 6 Missing and 1 partial ⚠️
dnsrocks/dnsserver/handler.go 61.53% 4 Missing and 1 partial ⚠️
dnsrocks/cmd/dnsrocks/dnsrocks.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   59.47%   59.24%   -0.23%     
==========================================
  Files          90       91       +1     
  Lines        8690     8831     +141     
==========================================
+ Hits         5168     5232      +64     
- Misses       3204     3263      +59     
- Partials      318      336      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d4d8634.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants