fix bugs in GetLocationByMap #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D62937783 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
===========================================
- Coverage 59.47% 25.40% -34.07%
===========================================
Files 90 19 -71
Lines 8690 1618 -7072
===========================================
- Hits 5168 411 -4757
+ Misses 3204 1166 -2038
+ Partials 318 41 -277 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D62937783 |
abulimov
added a commit
to abulimov/dns
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: facebook#78 Fix couple of bugs with location unpacking: * `GetLocationByMap` doesn't handle multi-value unpacking * Added more slice bound checks to harden the code. Reviewed By: leoleovich, deathowl Differential Revision: D62937783
abulimov
force-pushed
the
export-D62937783
branch
from
05ef807 to
a0ef902
Compare
Summary: Pull Request resolved: facebook#78 Fix couple of bugs with location unpacking: * `GetLocationByMap` doesn't handle multi-value unpacking * Added more slice bound checks to harden the code. Reviewed By: leoleovich, deathowl Differential Revision: D62937783
|
This pull request was exported from Phabricator. Differential Revision: D62937783 |
abulimov
force-pushed
the
export-D62937783
branch
from
a0ef902 to
736eeb5
Compare
|
This pull request has been merged in 6c2886e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix couple of bugs with location unpacking:
GetLocationByMapdoesn't handle multi-value unpackingReviewed By: deathowl
Differential Revision: D62937783