Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTML from routes #48

Open
ivan-unfolds opened this issue Sep 29, 2022 · 0 comments
Open

Remove HTML from routes #48

ivan-unfolds opened this issue Sep 29, 2022 · 0 comments

Comments

@ivan-unfolds
Copy link

ivan-unfolds commented Sep 29, 2022

At the moment you're setting some of the HTML in templates.js and some of it in your routes (specifically here)

It helps to have a separation of concerns between the routing logic and the templates as an app gets bigger. Say we want to know where a certain css class is set, we should only have to look in one place, ie where the templates live. As the code is at the moment, we would also have to look inside the server routes.

This is a bit difficult to explain in writing so I'll talk about during the live code review tomorrow. Let me know if you have any questions afterwards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant