feat: Event 엔티티와 서비스 구현 추가 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Event 엔티티와 EventStatus Enum 추가 - EventService와 EventServiceImpl 구현 - EventServiceImpl 단위 테스트 추가
f-lab-troy
reviewed
Feb 10, 2025
| private Long id; | ||
|
|
||
| private String name; | ||
| private String date_time; |
There was a problem hiding this comment.
날짜 시간은 String보다 관련 객체 사용을 추천드립니다.
변수 이름도 자바의 camel case사용을 권장드립니다.
| } | ||
|
|
||
| @Builder | ||
| public Event(Long id, String name, String date_time, String location, EventStatus status, LocalDateTime created_at, LocalDateTime updated_at) { |
There was a problem hiding this comment.
위 생성자를 불러서 코드의 중복을 줄일 수 있을 것으로 보입니다.
| import static org.mockito.Mockito.when; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| public class EventServiceImplTest { |
넵 알겠습니다! 수정된 코드들을 다시 브랜치 생성하여 PR 요청하겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 변경 사항