Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About temporal editing evaluation #1

Open
RohollahHS opened this issue Aug 31, 2024 · 2 comments
Open

About temporal editing evaluation #1

RohollahHS opened this issue Aug 31, 2024 · 2 comments

Comments

@RohollahHS
Copy link

RohollahHS commented Aug 31, 2024

Greate work. Congrats.

In Fig. 7 of BAMM paper, the blue meshes are corresponding to the blue texts, and the red meshes to the red texts.

In Table 5 of the paper "Table 5: Evaluation on temporal editing tasks on HumanML3D dataset", did you evaluate your model like the Fig. 7?
I mean did you use the same text prompt for unmasked tokens to predict masked tokens? Or, you randomly used different text prompts for masked tokens and unmasked tokens (Similar to Fig. 7)?

Based on the contents in Section "4.2 Length Prediction and Editablity", I think you used the same text prompts for unmasked and masked tokens for evaluation, but different text prompts for generation. Am I correct?

image

If I want to generate some motions for temporal editing tasks, do I have to use different text prompts for unmasked tokens and masked tokens (like Fig. 7)?

Thanks

@exitudio
Copy link
Owner

exitudio commented Sep 1, 2024

Hi Syed,

  1. Evaluation (Table 5): we used same text prompt for evaluation since there is ground truth to evaluate the different text prompts.
  2. Generation (Fig. 7): we generate twice. First generate the whole sequence based on blue text. Then mask out the red parts. And generate the masked parts with red text. Use can follow the example of MMM "In-between" section.

@RohollahHS
Copy link
Author

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants