Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resistor-color-trio exercise #250

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

keiravillekode
Copy link
Contributor

No description provided.

config.json Outdated
"uuid": "1eae864e-ecb8-4ccd-8b58-2a4092c0410f",
"practices": [],
"prerequisites": [],
"difficulty": 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this really have the same difficulty as resistor-color? Looking at their problem descriptions, I'd suggest resistor-color-trio should have the higher difficulty. If it helps, the Go track uses 2 for resistor-color and 4 for resistor-color-trio.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to have the resistor-color exercises appear together when the exercises are sorted by (difficulty, slug). Now changed.

description = "Maximum possible value"

[0061a76c-903a-4714-8ce2-f26ce23b0e09]
description = "First two colors make an invalid octal number"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case and the next one is missing from the tests.

Copy link
Contributor Author

@keiravillekode keiravillekode Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end I added 4 tests, that I think first appeared in the Julia track. This way, we have coverage of all colors in the third position, and we have output containing a decimal point.

The last two tests in tests.toml become the 5th-last and sixth-last tests in run_tests.v

@kahgoh kahgoh merged commit 40b4dcb into exercism:main Apr 7, 2025
4 checks passed
@keiravillekode keiravillekode deleted the resistor-color-trio branch April 7, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants