-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resistor-color-trio exercise #250
Conversation
config.json
Outdated
"uuid": "1eae864e-ecb8-4ccd-8b58-2a4092c0410f", | ||
"practices": [], | ||
"prerequisites": [], | ||
"difficulty": 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this really have the same difficulty as resistor-color
? Looking at their problem descriptions, I'd suggest resistor-color-trio
should have the higher difficulty. If it helps, the Go track uses 2 for resistor-color
and 4 for resistor-color-trio
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to have the resistor-color
exercises appear together when the exercises are sorted by (difficulty, slug). Now changed.
description = "Maximum possible value" | ||
|
||
[0061a76c-903a-4714-8ce2-f26ce23b0e09] | ||
description = "First two colors make an invalid octal number" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case and the next one is missing from the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the end I added 4 tests, that I think first appeared in the Julia track. This way, we have coverage of all colors in the third position, and we have output containing a decimal point.
The last two tests in tests.toml
become the 5th-last and sixth-last tests in run_tests.v
No description provided.