Add change exercise
#386
Merged
Add change exercise
#386
+230
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
commented
Jan 22, 2025
| stopifnot(target > 0) | ||
| stopifnot(min(coins) <= target) | ||
|
|
||
| min_amount_coins <- rep(Inf, target + 1) |
There was a problem hiding this comment.
I struggled a bit with how to model the "the value is not yet there at that index" placeholder. I'm open to suggestions how to improve
There was a problem hiding this comment.
Conventionally, this would use NA. Line 9 then becomes
min_amount_coins <- rep(NA, target + 1)and line 27 becomes
stopifnot(!is.na(min_amount_coins[[target + 1]]))The tests still pass when I tested this locally. Is that the sort of thing you were asking about?
colinleach
approved these changes
Jan 22, 2025
|
Yeah, I'll to make it clearer using |
ErikSchierboom
force-pushed
the
change
branch
from
ab6027e to
93f8cf1
Compare
ErikSchierboom
force-pushed
the
change
branch
from
93f8cf1 to
f12953a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.