Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercises/practice/anagram: add an append with instructions about the order of the return values #848

Closed
wants to merge 1 commit into from

Conversation

IsaacG
Copy link
Member

@IsaacG IsaacG commented Jan 15, 2025

No description provided.

@verdammelt
Copy link
Member

@IsaacG is this new description actually representative of what this track currently does?

If Exercism(TM) has decided that the exercise is to check that the right set of anagrams is found (i.e. unordered collection) then in my opinion this track should use the PR #847 which ensures the tests do not accidentally test for any specific ordering.

Am I correct that the decision (from this thread: https://forum.exercism.org/t/anagram-exercise-instructions-and-tests-dont-align-on-ordering/14816/48) is that the problem by itself (without appended text) be for an unordered collection?

@BNAndras
Copy link
Member

My understanding is that once we come to a consensus, the new instructions won't imply whether an ordered or unordered collection is expected so the student isn't influenced one way or the other. To that end, the append clarifies what the track expects. So that other PR should be resolved first, and then the append in this PR can be updated to reflect what the track now expects. However, you can also choose not to merge this PR.

@IsaacG
Copy link
Member Author

IsaacG commented Jan 16, 2025

Clarify what this track expects. Context: https://forum.exercism.org/t/14816/

@IsaacG
Copy link
Member Author

IsaacG commented Jan 16, 2025

What @BNAndras said. The current instructions are ambiguous. Does "a set of anagrams" in prose mean a set object containing the anagrams? Or is "set" meant in the colloquial meaning, ie a collection/group? Many tracks do not have a set object. Most tracks expect a list object, not a set object.

The problem spec is being updated to avoid using the word "set" to remove that confusion ... and learning the implementation details unspecified. Tracks can use any data type they prefer. Some tracks expect a comma-separated string. Most expect a list. Some expect a set. Some expect text to be written to a filehandle (STDOUT). C expects a connection of objects to be updated, where each object has a Boolean is_anagram value.

The append file allows tracks to (optionally) explicitly state expectations. The append file is certainly not required. It is supposed to reflect the existing track tests (if I read them right).

@verdammelt
Copy link
Member

I plan on merging #847 so I don't think we want/need this change anymore

@verdammelt verdammelt closed this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants