moved HALO specifics navigation data to function #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support multiple platforms, specific code of loading platform navigation data should be factored out to specific functions. These can be collected in navdata.py. Dispatching to the correct function is done based on the `platform` attribute of each flight.
RobertPincus
approved these changes
Jul 31, 2020
|
Thanks @RobertPincus for reviewing, will you merge it if you are happy with the situation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support multiple platforms, specific code of loading platform navigation data should be factored out to specific functions. These can be collected in navdata.py. Dispatching to the correct function is done based on the
platformattribute of each flight.This PR should help with #3 and also includes a method to obtain HALO flight data from Aeris via opendap.