Quaive app for merge part 3: ploneintranet module #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are registered for `osha.oira.ploneintranet.interfaces.IQuaiveForm`.
Then we get our special z3cform widgets. Add accompanying `templates/quaive-form.pt`.
They are called `quaive-create-<portal_type>`, so `quaive-create-euphorie.sector`, etc.
Nothing is actually done, this only displays text. On the Quaive side, this text is shown with buttons to accompany it. Originally on the `quaive-app` branch we had `@@quaive-versions` as well, but this was no longer called from Quaive. This included a button pointing to `@@quaive-unpublish` as well, but this did not exist. Anyway, both are not needed by Quaive.
ale-rt
approved these changes
Jan 31, 2025
| <li> | ||
| <button class="button-heading-level-2 icon-header" | ||
| type="button" | ||
| >Header level 2</button> |
There was a problem hiding this comment.
We are missing some i18n:translate here and in the other buttons, but ok.
| <span class="button-field type-url"> | ||
| <input class="pat-autofocus" | ||
| name="tiptap-src" | ||
| oninput="if (this.value) { this.nextElementSibling.href = this.value; } else { this.nextElementSibling.removeAttribute('href'); }" |
Comment on lines
+1
to
+9
| _applied = False | ||
|
|
||
| if not _applied: | ||
| from z3c.form.form import Form | ||
|
|
||
| # Zap the totally useless 'There were some errors' message. | ||
| Form.formErrorsMessage = None | ||
| del Form | ||
| _applied = True |
There was a problem hiding this comment.
I was a bit puzzled about this and found out that it comes from copying the NuPlone folder.
I think wee can remove it:
Suggested change
| _applied = False | |
| if not _applied: | |
| from z3c.form.form import Form | |
| # Zap the totally useless 'There were some errors' message. | |
| Form.formErrorsMessage = None | |
| del Form | |
| _applied = True |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on PR #308, though technically it could be merged separately.
This adds z3cform widgets for nicely showing in Quaive, adds create and edit forms for the euphorie content, and adds a page used for publishing a survey in Quaive.
Compared with the original
quaive-appbranch, we have everything needed now. Differences:templates/sector_edit.pt, already in the other PR.@@quaive-versions, which was actually no longer used on the Quaive side.