New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library simplification #110

Merged

babisRoutis merged 16 commits into eu-digital-identity-wallet:main from niscy-eudiw:feature/simplify-library

Nov 27, 2023

Contributor

dzarras commented Nov 24, 2023

Closes #109

dzarras added 2 commits

November 24, 2023 12:18


          Update kotlin to v1.9.21

ca75594


          Update ktor to v2.3.6

aa201b2

dzarras added the feature label

dzarras requested a review from babisRoutis

November 24, 2023 10:26

dzarras assigned babisRoutis

dzarras added 3 commits

November 24, 2023 14:34


          Remove HttpGet and HttpPost abstractions.

6a09843


          Update and simplify default implementations.

e3cbd77


          Introduce data objects.

fa597e8

Contributor Author

dzarras commented Nov 24, 2023

@babisRoutis could you take a look and let me know of any comments?

babisRoutis reviewed

View reviewed changes

src/main/kotlin/eu/europa/ec/eudi/openid4vp/internal/DefaultSiopOpenId4Vp.kt Outdated Show resolved Hide resolved


          Remove DefaultSiopOpenId4Vp

e4dc980

babisRoutis reviewed

View reviewed changes

src/main/kotlin/eu/europa/ec/eudi/openid4vp/Ηttp.kt Outdated Show resolved Hide resolved

babisRoutis reviewed

View reviewed changes

src/main/kotlin/eu/europa/ec/eudi/openid4vp/SiopOpenId4Vp.kt Outdated Show resolved Hide resolved

babisRoutis reviewed

View reviewed changes

src/main/kotlin/eu/europa/ec/eudi/openid4vp/Ηttp.kt Outdated Show resolved Hide resolved

babisRoutis reviewed

View reviewed changes

src/main/kotlin/eu/europa/ec/eudi/openid4vp/Dispatcher.kt Outdated Show resolved Hide resolved

dzarras and others added 7 commits

November 24, 2023 17:10


          Move Http extension methods in Types.

da989dc


          Prefer operator fun invoke() in companion objects for factory methods.

9a6856d


          UnvalidatedClientMetaData is an internal implementation detail.


          RequestObject and AuthorizationRequest are internal implementatio…

15d3656

…n details.


          Removed Dispatchers.IO as param

d2cbcd9


          Some code formating

55c9a81


          Remove unneeded coroutine scope builder.

307bd3e

babisRoutis marked this pull request as ready for review

November 27, 2023 07:40

babisRoutis requested a review from a team as a code owner

November 27, 2023 07:40

dzarras and others added 3 commits

November 27, 2023 09:52


          Documentation update.

8a8f6bc


          Replace usages of JWKSet.load(URL) with a Ktor get request + `JWKSe…

68895a7

…t.parse(String)`


          Update the foojay-resolver-convention plugin to 0.7.0

fdd37a8

sonarqubecloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

babisRoutis approved these changes

View reviewed changes

babisRoutis merged commit 8a0a189 into eu-digital-identity-wallet:main

3 checks passed

babisRoutis deleted the feature/simplify-library branch

November 27, 2023 08:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature