Ensure GAMS can run all the benchmarks #183
Conversation
olejandro
changed the title
olejandro
changed the title
|
#181 would need to be finished first to (hopefully) resolve domain violations in |
|
Also there are |
|
What is the reasoning for including in |
|
Thanks, @Antti-L. No particular reason, except for the other types not present in any of the benchmarks and the ease with which the list can be expanded. I can include all of them already. I.e. all members of |
|
Opened #194 based on results from CI, but also modified benchmarks to allow a successful GAMS run on Ireland. |
| @@ -205,6 +206,7 @@ def __init__( | |||
| self.all_attributes, | |||
| param_mappings, | |||
| ) = Config._process_times_info(times_info_file) | |||
| self.times_sets = Config._read_times_sets(times_sets_file) | |||
There was a problem hiding this comment.
We should also add a type annotation for times_sets after line 193
…-excel-reader into olex/update-benchmarks
Now I remember why I used subprocess to call `xl2times` from `run_benchmarks.py`: in the CI, when it switches to the main branch, it needs to run the main branch's version of the tool. But if we call the tool as a python function, I think some of the PR version of the tool remains in memory, and we don't get what we want. This looks to be the reason CI is failing on this PR #183 : https://github.com/etsap-TIMES/xl2times/actions/runs/8020431584/job/21910275023 (The error is that it can't find a file in `xl2times/config/...` that was added by the PR when it is running tests in the main branch.) This PR undoes the change from #193 that removed the use of subprocess. See also https://github.com/etsap-TIMES/xl2times/pull/193/files?diff=unified&w=0#r1498683705
No description provided.