Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UC: handling inconsistent UC_Sets and UC_RHS* #291

Open
olejandro opened this issue Jan 17, 2025 · 2 comments
Open

UC: handling inconsistent UC_Sets and UC_RHS* #291

olejandro opened this issue Jan 17, 2025 · 2 comments

Comments

@olejandro
Copy link
Member

Sometimes user may specify inconsistent UC_Sets and UC_RHS*. How should we handle it, apart from issuing a warning?
We could:

  • drop the constraint
  • make UC_Sets consistent with UC_RHS* (I believe that's what Veda does)
  • make UC_RHS* consistent with UC_Sets
@olejandro
Copy link
Member Author

@Antti-L do you have any advice on this?

@Antti-L
Copy link

Antti-L commented Jan 17, 2025

I think a warning should be mostly quite sufficient.

  • There is no need to define UC_Sets at all, because TIMES has defaults for all of them, so leaving them empty should be fine
  • The user may well define the UC coefficients in a ~UC_T table, and then the UC_RHSxxx according to scenario (using TFM* tables).
  • Specfically, UC_T_* and UC_TS_* should at least never be auto-generated (I hope VEDA does not do any such?)
  • I don't quite see how making UC_RHS* consistent with UC_Sets could be done reliably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants