Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a unit test for create_regexp #222

Open
olejandro opened this issue Mar 15, 2024 · 0 comments
Open

Add a unit test for create_regexp #222

olejandro opened this issue Mar 15, 2024 · 0 comments
Assignees
@siddharth-krishna

Comments

@olejandro
Copy link
Member

olejandro commented Mar 15, 2024 •
edited by siddharth-krishna
Loading

Very exciting! Code looks good at a high level, but I'm not sure I follow the logic in detail. If you have time, it would be great to have a docstring on filter_by_pattern explaining the combined argument, and perhaps a unit test for create_regexp with an example demonstrating the white space removal and handling of comma separated values? Thanks

Originally posted by @siddharth-krishna in #219 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siddharth-krishna siddharth-krishna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@siddharth-krishna @olejandro