Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve URL handling #174

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

feat: improve URL handling #174

wants to merge 23 commits into from
+855 −244

Conversation

edobry
Copy link
Contributor

@edobry edobry commented Feb 14, 2025 •
edited
Loading

This PR reworks the URL/port handling across all modules to simplify & standardize our Starlark practices. It accomplishes this by:

  • extracting common port IDs to constants
  • implementing util methods like make_service_http_url, make_execution_rpc_url, make_execution_engine_url, etc
  • standardizing Service construction to minimize toil & surface area for human error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigma sigma sigma approved these changes

@scharissis scharissis scharissis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edobry @sigma @scharissis