fix: additional fixes for rollup-boost drift #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SozinM
changed the title
SozinM
force-pushed
the
msozin/rollup-boost-updates
branch
from
31cb005 to
89d005c
Compare
SozinM
changed the title
This was referenced Feb 12, 2025
SozinM
force-pushed
the
msozin/rollup-boost-updates
branch
from
a858554 to
ccc3ba5
Compare
SozinM
force-pushed
the
msozin/rollup-boost-updates
branch
from
90e1f1b to
ef76286
Compare
|
@SozinM seeing lint error, can you run |
Added default_key to default participant
Removed sequencer_enabled = False as it's confusing Stopped deployment of CL builder for external builder
SozinM
force-pushed
the
msozin/rollup-boost-updates
branch
from
ef76286 to
cd1c8e7
Compare
zhwrd
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Rollup-boost encountered issues due to configuration drift.
Description
While the primary drift problem was resolved in PR #147, follow-up testing uncovered additional inconsistencies that require further adjustments.
This issue proposes targeted fixes based on local test results and addresses the rest of inconsistencies.
Also couple of uncovered bugs were addressed (mainly with external builder)
Removed this as it was causing a bug + was confusing
Changed behavior of builder consensus node. Now if external builder is used it should setup consensus node outside of enclave too.