Skip to content

Commit

Permalink
fix: make kt run . without --args-file run without error
Browse files Browse the repository at this point in the history
every software should run fine even without a config file
  • Loading branch information
samlaf committed Feb 11, 2025
1 parent cc29f6e commit cafb835
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 1 deletion.
17 changes: 17 additions & 0 deletions .github/workflows/per-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,23 @@ jobs:
- name: Run Starlark
run: kurtosis run ${{ github.workspace }} --args-file ${{ matrix.file_name }} --verbosity detailed

# Make sure that `kurtosis run .` without an --args-file works fine (the defaults in input_parser.star are correct)
run_without_args:
runs-on: ubuntu-latest
steps:
- name: Checkout Repository
uses: actions/checkout@v4

- name: Setup Kurtosis
run: |
echo "deb [trusted=yes] https://apt.fury.io/kurtosis-tech/ /" | sudo tee /etc/apt/sources.list.d/kurtosis.list
sudo apt update
sudo apt install kurtosis-cli
kurtosis analytics disable
- name: Run Starlark
run: kurtosis run ${{ github.workspace }} --verbosity detailed

lint:
runs-on: ubuntu-latest
steps:
Expand Down
8 changes: 7 additions & 1 deletion src/package_io/input_parser.star
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ def default_optimism_params():
return {
"observability": default_observability_params(),
"interop": default_interop_params(),
"altda": default_altda_deploy_config(),
"altda_deploy_config": default_altda_deploy_config(),
"chains": default_chains(),
"op_contract_deployer_params": default_op_contract_deployer_params(),
"global_log_level": "info",
Expand Down Expand Up @@ -614,6 +614,12 @@ def default_op_contract_deployer_params():

def default_ethereum_package_network_params():
return {
"participants": [
{
"el_type": "geth",
"cl_type": "teku",
}
],
"network_params": {
"preset": "minimal",
"genesis_delay": 5,
Expand Down
1 change: 1 addition & 0 deletions src/package_io/sanity_check.star
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ SUBCATEGORY_PARAMS = {
"proposer_params": ["image", "extra_params", "game_type", "proposal_interval"],
"mev_params": ["rollup_boost_image", "builder_host", "builder_port"],
"da_server_params": [
"enabled",
"image",
"cmd",
],
Expand Down

0 comments on commit cafb835

Please sign in to comment.