Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added type check for apiKey as string #133

Merged
merged 2 commits into from
Sep 17, 2024
Merged

added type check for apiKey as string #133

merged 2 commits into from
Sep 17, 2024

Conversation

vignesha22
Copy link
Contributor

Description

  • Added type checks for apiKey as string

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@linear Linear
Copy link

linear bot commented Sep 17, 2024

PRO-2685 Arka Error Handling

@vignesha22 vignesha22 self-assigned this Sep 17, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 17, 2024 •
edited
Loading

Deploying arka with  Cloudflare Pages  Cloudflare Pages

Latest commit: 611e64f
Status: ✅  Deploy successful!
Preview URL: https://ad3cd2e7.arka-3qg.pages.dev
Branch Preview URL: https://pro-2685-bug-fixes.arka-3qg.pages.dev

View logs

@vignesha22 vignesha22 merged commit 151fc3f into master Sep 17, 2024
4 checks passed
@vignesha22 vignesha22 deleted the PRO-2685-Bug_Fixes branch September 17, 2024 14:16
nikhilkumar1612
nikhilkumar1612 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@nikhilkumar1612 nikhilkumar1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 lgtm 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilkumar1612 nikhilkumar1612 nikhilkumar1612 approved these changes

@arddluma arddluma arddluma approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@kanthgithub kanthgithub Awaiting requested review from kanthgithub

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

@cryptonoyaiba cryptonoyaiba Awaiting requested review from cryptonoyaiba

Assignees

@vignesha22 vignesha22

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vignesha22 @ch4r10t33r @arddluma @nikhilkumar1612