Skip to content
This repository was archived by the owner on Jun 3, 2022. It is now read-only.

Rename eth_sendRawTransaction to eth_sendSignedTransaction #10

Open
Georgi87 opened this issue Jan 27, 2017 · 3 comments
Open

Rename eth_sendRawTransaction to eth_sendSignedTransaction #10

Georgi87 opened this issue Jan 27, 2017 · 3 comments
Labels

Comments

@Georgi87
Copy link

Georgi87 commented Jan 27, 2017

The naming for the RPC call eth_sendRawTransaction is misleading as this call allows to send a signed transaction. The term raw is used in the context of transactions for unsigned data (raw transaction hash). Changing the RPC name to eth_sendSignedTransaction would make the usage more clear and prevent misuse.

@Georgi87 Georgi87 changed the title Rename eth_sendRawTransaction to eth_sendSignedTransaction Rename sendRawTransaction to sendSignedTransaction Jan 27, 2017
@frozeman frozeman changed the title Rename sendRawTransaction to sendSignedTransaction Rename eth_sendRawTransaction to eth_sendSignedTransaction Jan 27, 2017
@frozeman
Copy link

frozeman commented Jan 27, 2017

I fully support this and in web3.js 1.0 it will be already called eth.sendSignedTransaction()
@bas-vk @obscuren can we change that and deprecate the old name?

The name was initially given by @SilentCicero who just came up with the name and i didn't had much time to think about a better one back then.

@kumavis
Copy link
Member

kumavis commented Jan 29, 2017

parity recently introduced eth_submitTransaction as an alias to eth_sendRawTransaction
https://github.com/ethcore/parity/blob/8404edb656693270ec1cd3956d204f625d28ec7c/rpc/src/v1/traits/eth.rs#L108-L109

@Georgi87
Copy link
Author

Good to see parity also sees this as an issue. I think the difference between submitTransaction and sendTransaction is not really obvious with this naming but it is much better than sendRawTransaction.

@frozeman frozeman added the ERC label May 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants