Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Rename StemFromBytes to StemFromLEBytes #427

Merged
merged 2 commits into from
Feb 29, 2024
+7 −7
Merged

chore!: Rename StemFromBytes to StemFromLEBytes #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83c3354
rename `StemFromBytes` to `StemFromLEBytes
kevaundray Feb 17, 2024
5895e58
refactor code to match
kevaundray Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conversion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func BatchNewLeafNode(nodesValues []BatchNewLeafNodeData) ([]LeafNode, error) {
var poly [NodeWidth]Fr
poly[0].SetUint64(1)
for i, nv := range nodesValues {
if err := StemFromBytes(&poly[1], nv.Stem); err != nil {
if err := StemFromLEBytes(&poly[1], nv.Stem); err != nil {
return err
}
poly[2] = *c1c2frs[2*i]
Expand Down
2 changes: 1 addition & 1 deletion ipa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func FromLEBytes(fr *Fr, data []byte) error {
return nil
}

func StemFromBytes(fr *Fr, data []byte) error {
func StemFromLEBytes(fr *Fr, data []byte) error {
if len(data) != StemSize {
return errors.New("data length must be StemSize")
}
Expand Down
4 changes: 2 additions & 2 deletions tree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ func NewLeafNode(stem Stem, values [][]byte) (*LeafNode, error) {
stem = stem[:StemSize] // enforce a 31-byte length
var poly [NodeWidth]Fr
poly[0].SetUint64(1)
if err := StemFromBytes(&poly[1], stem); err != nil {
if err := StemFromLEBytes(&poly[1], stem); err != nil {
return nil, err
}
if err := banderwagon.BatchMapToScalarField([]*Fr{&poly[2], &poly[3]}, []*Point{c1, c2}); err != nil {
Expand Down Expand Up @@ -1434,7 +1434,7 @@ func (n *LeafNode) GetProofItems(keys keylist, _ NodeResolverFn) (*ProofElements

// Initialize the top-level polynomial with 1 + stem + C1 + C2
poly[0].SetUint64(1)
if err := StemFromBytes(&poly[1], n.stem); err != nil {
if err := StemFromLEBytes(&poly[1], n.stem); err != nil {
return nil, nil, nil, fmt.Errorf("error serializing stem '%x': %w", n.stem, err)
}

Expand Down
6 changes: 3 additions & 3 deletions tree_ipa_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func extensionAndSuffixOneKey(t *testing.T, key, value []byte, ret *Point) {
t1, t2, c1 Point
)
stemComm0 := srs[0]
err := StemFromBytes(&v, KeyToStem(key))
err := StemFromLEBytes(&v, KeyToStem(key))
if err != nil {
panic(err)
}
Expand Down Expand Up @@ -165,7 +165,7 @@ func TestInsertSameStemTwoLeaves(t *testing.T) {
comm := root.Commit()

stemComm0 := srs[0]
err := StemFromBytes(&v, KeyToStem(key_a))
err := StemFromLEBytes(&v, KeyToStem(key_a))
if err != nil {
t.Fatal(err)
}
Expand Down Expand Up @@ -309,7 +309,7 @@ func TestPaddingInFromLEBytes(t *testing.T) {
t.Fatal(err)
}
key, _ := hex.DecodeString("ffffffffffffffffffffffffffffffff00000000000000000000000000000000")
err := StemFromBytes(&fr2, KeyToStem(key))
err := StemFromLEBytes(&fr2, KeyToStem(key))
if err != nil {
t.Fatal(err)
}
Expand Down
Loading