Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type import comment #885

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

gurukamath
Copy link
Collaborator

(closes #880)

What was wrong?

The type import comment is no longer needed.

Related to Issue #880

How was it fixed?

Added a py.typed file in the consensus-specs

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@gurukamath gurukamath marked this pull request as draft February 16, 2024 14:55
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bf47143) 69.96% compared to head (ddf44a0) 69.64%.
Report is 36 commits behind head on forks/cancun.

Files Patch % Lines
...ancun/vm/precompiled_contracts/point_evaluation.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           forks/cancun     #885      +/-   ##
================================================
- Coverage         69.96%   69.64%   -0.32%     
================================================
  Files               610      611       +1     
  Lines             34295    34898     +603     
================================================
+ Hits              23993    24306     +313     
- Misses            10302    10592     +290     
Flag Coverage Δ
unittests 69.64% <0.00%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gurukamath gurukamath marked this pull request as ready for review February 17, 2024 15:41
@gurukamath gurukamath requested a review from SamWilsn February 17, 2024 15:42
@SamWilsn SamWilsn merged commit 457e562 into ethereum:forks/cancun Feb 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants