Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor make_receipt's control flow to be more coherent #884

Merged

Conversation

richardgreg
Copy link
Contributor

What was wrong?

In fork.py's make_receipt, multiple if/return blocks are followed by an else
Related to Issue #
#874

How was it fixed?

Simple refactoring. Use if/elif/else flow

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4d95303) 74.12% compared to head (ed6087d) 74.12%.

Files Patch % Lines
src/ethereum/arrow_glacier/fork.py 0.00% 1 Missing ⚠️
src/ethereum/gray_glacier/fork.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #884   +/-   ##
=======================================
  Coverage   74.12%   74.12%           
=======================================
  Files         572      572           
  Lines       32419    32419           
=======================================
  Hits        24030    24030           
  Misses       8389     8389           
Flag Coverage Δ
unittests 74.12% <60.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gurukamath gurukamath merged commit 9ca885c into ethereum:master Feb 20, 2024
5 checks passed
@gurukamath gurukamath mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants