Replace gas_available with gas_used in the description of apply_body #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWilsn
reviewed
Jan 31, 2024
src/ethereum/arrow_glacier/fork.py
Outdated
| @@ -533,8 +533,8 @@ def apply_body( | |||
|
|
|||
| Returns | |||
| ------- | |||
| gas_available : `ethereum.base_types.Uint` | |||
| Remaining gas after all transactions have been executed. | |||
| gas_used : `ethereum.base_types.Uint` | |||
There was a problem hiding this comment.
Maybe
Suggested change
| gas_used : `ethereum.base_types.Uint` | |
| block_gas_used : `ethereum.base_types.Uint` |
to match the actual variable name?
If you don't want to change it, I'm fine merging as-is too. We're switching to markdown shortly anyway.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #872 +/- ##
=======================================
Coverage 74.11% 74.11%
=======================================
Files 572 572
Lines 32411 32411
=======================================
Hits 24022 24022
Misses 8389 8389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SamWilsn
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The first return value in the description of
apply_bodyisgas_availableinstead ofgas_used.How was it fixed?
Replacing
gas_availablewithgas_used.Cute Animal Picture