Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change type of branch node subnodes (Prague port) #1095

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

SamWilsn
Copy link
Contributor

What was wrong?

Related to Issue #1066

@SamWilsn SamWilsn requested a review from gurukamath January 25, 2025 18:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.77%. Comparing base (0c56b70) to head (aa1adc4).

Additional details and impacted files
@@              Coverage Diff              @@
##           forks/prague    #1095   +/-   ##
=============================================
  Coverage         14.77%   14.77%           
=============================================
  Files               697      697           
  Lines             39092    39095    +3     
=============================================
+ Hits               5775     5778    +3     
  Misses            33317    33317           
Flag Coverage Δ
unittests 14.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gurukamath gurukamath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depencency in setup.cfg should be updated to typing_extensions>=4.2

@SamWilsn SamWilsn force-pushed the change-type-branch-nodes branch from aa1adc4 to a392ebb Compare January 27, 2025 14:11
@SamWilsn SamWilsn merged commit b151dfe into ethereum:forks/prague Jan 27, 2025
4 checks passed
@SamWilsn SamWilsn deleted the change-type-branch-nodes branch January 27, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants