Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7873: memory expansion of TXCREATE and remove 3860 charge mention #9377

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Feb 18, 2025

Rectifies two minor details I've found after reading the EIP post-merge

@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Feb 18, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 18, 2025

✅ All reviewers have approved.

@pdobacz
Copy link
Contributor Author

pdobacz commented Feb 18, 2025

@gumb0 notes that memory gas charge shouldn't be moved, so instead we fix the wording to not be ambiguous as to what is charged on light failure scenarios (memory gas is charged, same as EOFCREATE)

@pdobacz pdobacz force-pushed the fixup-7873-txcreate branch from a5cfb6c to a053071 Compare February 18, 2025 12:21
@pdobacz pdobacz marked this pull request as ready for review February 18, 2025 16:18
@pdobacz pdobacz requested a review from eth-bot as a code owner February 18, 2025 16:18
@pdobacz pdobacz closed this Feb 18, 2025
@pdobacz pdobacz reopened this Feb 18, 2025
@eth-bot eth-bot enabled auto-merge (squash) February 18, 2025 16:41
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit fa5ceb2 into ethereum:master Feb 18, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants