fix(ctb): LibKeccak version bump

[clabby]

Overview

Bumps the version of lib-keccak in contracts-bedrock to 0115edbbc60b5f702392caafc3a142061e6142fa, which contains a fix for a memory allocation edge case.

[clabby]

Current dependencies on/for this PR:

• develop
  • PR fix(ctb): LibKeccak version bump #9167 👈

This stack of pull requests is managed by Graphite.

[coderabbitai]

Walkthrough

Walkthrough

The update details a change in the version control references for a subproject within the packages/contracts-bedrock library, specifically the lib-keccak component. The subproject's commit reference has been advanced from an older commit (59dcbd7b0de1fd00b44f4ce41e99a7f990564d11) to a newer one (0115edbbc60b5f702392caafc3a142061e6142fa), indicating a likely incorporation of new features, bug fixes, or other modifications.

Changes

Files or Directories	Summary of Changes
lib-keccak	Updated the subproject commit reference from 59dcbd7... to 0115edbbc....

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c47f044) 28.33% compared to head (e3ee87c) 16.91%.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #9167       +/-   ##
============================================
- Coverage    28.33%   16.91%   -11.42%     
============================================
  Files          166      118       -48     
  Lines         7289     4991     -2298     
  Branches      1241     1090      -151     
============================================
- Hits          2065      844     -1221     
+ Misses        5103     4072     -1031     
+ Partials       121       75       -46     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	?
contracts-bedrock-tests	0.67% <ø> (ø)
contracts-ts-tests	12.25% <ø> (ø)
core-utils-tests	?
sdk-next-tests	42.08% <ø> (ø)
sdk-tests	42.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 48 files with indirect coverage changes

[Ezra-Labs]

Hi, not sure what happened here, but I have again gone through the rollup tutorial again (will probably do several more times), and on the step for pnpm build, hitting a snag where the files in this specific folder aren't present after the git clone.

End of Terminal log for pnpm build:

   Error: 
   failed to resolve file: "/Users/davidowens/ent2/optimism/packages/contracts-bedrock/lib/clones-with-immutable-args/src/ClonesWithImmutableArgs.sol": No such file or directory (os error 2); check configured remappings.
       --> "/Users/davidowens/ent2/optimism/packages/contracts-bedrock/src/dispute/DisputeGameFactory.sol"
           "@cwia/ClonesWithImmutableArgs.sol"
    ELIFECYCLE  Command failed with exit code 1.

——————————————————————————————————————————————————————————————————————————————

NX Ran target build for 8 projects (1m)

✔    2/3 succeeded [2 read from cache]

✖    1/3 targets failed, including the following:
     - nx run @eth-optimism/contracts-bedrock:build

View structured, searchable error logs at https://nx.app/runs/1iSJIRlEeh

 ELIFECYCLE  Command failed with exit code 1.

[Ezra-Labs]

That specific folder is currently empty locally. After two attempts.

[clabby]

That specific folder is currently empty locally. After two attempts.

Try to cd into packages/contracts-bedrock and forge install 😄

[Ezra-Labs]

done, no change.

" > forge build

   Error: 
   failed to resolve file: "/Users/davidowens/ent2/optimism/packages/contracts-bedrock/lib/clones-with-immutable-args/src/ClonesWithImmutableArgs.sol": No such file or directory (os error 2); check configured remappings.
       --> "/Users/davidowens/ent2/optimism/packages/contracts-bedrock/src/dispute/DisputeGameFactory.sol"
           "@cwia/ClonesWithImmutableArgs.sol"
    ELIFECYCLE  Command failed with exit code 1.

——————————————————————————————————————————————————————————————————————————————

NX Ran target build for 8 projects (3s)

✔    2/3 succeeded [2 read from cache]

✖    1/3 targets failed, including the following:
     - nx run @eth-optimism/contracts-bedrock:build

View structured, searchable error logs at https://nx.app/runs/qHrAIGPiJk

 ELIFECYCLE  Command failed with exit code 1."

Ive gone through this tutorial several times in several directories in same manner, this is a new error not seen before.

[jin2255]

hi @Ezra-Labs
did you fix the error, or same yet?
I've got same issue