Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MT Cannon: add more cannon operator instr tests #12104

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

GrapeBaBa
Copy link
Contributor

Description
This PR add sub/subu/and/andi/or/ori/xor/xori/nor/slt/sltu tests

Tests

Additional context

Metadata

Signed-off-by: Chen Kai <281165273grape@gmail.com>
@GrapeBaBa GrapeBaBa requested review from a team as code owners September 25, 2024 10:20
@GrapeBaBa GrapeBaBa requested a review from mbaxter September 25, 2024 10:20
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (decf451) to head (f33d786).
Report is 29 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12104      +/-   ##
===========================================
- Coverage    68.32%   68.13%   -0.20%     
===========================================
  Files           54       54              
  Lines         4117     4117              
===========================================
- Hits          2813     2805       -8     
- Misses        1125     1134       +9     
+ Partials       179      178       -1     
Flag Coverage Δ
cannon-go-tests 68.13% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

cannon/mipsevm/tests/evm_common_test.go Outdated Show resolved Hide resolved
cannon/mipsevm/tests/evm_common_test.go Outdated Show resolved Hide resolved
cannon/mipsevm/tests/evm_common_test.go Outdated Show resolved Hide resolved
Signed-off-by: Chen Kai <281165273grape@gmail.com>
@mbaxter mbaxter added this pull request to the merge queue Sep 26, 2024
Merged via the queue into ethereum-optimism:develop with commit e1fe38e Sep 26, 2024
63 checks passed
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
)

* feat:add more cannon operator instr tests

Signed-off-by: Chen Kai <281165273grape@gmail.com>

* feat:code review suggestion fix

Signed-off-by: Chen Kai <281165273grape@gmail.com>

---------

Signed-off-by: Chen Kai <281165273grape@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MTCannon: Create more operator related tests
2 participants