20250216 bump go linter 1.24 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elbehery
force-pushed
the
20250216-bump-go-linter-1.24
branch
2 times, most recently
from
7b5b4b7 to
ee42474
Compare
ivanvc
reviewed
Feb 20, 2025
.github/workflows/golangci-lint.yml
Outdated
| @@ -27,7 +27,7 @@ jobs: | |||
| uses: golangci/golangci-lint-action@2e788936b09dd82dc280e845628a40d2ba6b204c # v6.3.1 | |||
| with: | |||
| # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version | |||
| version: v1.57.1 | |||
| version: v1.63.4 | |||
There was a problem hiding this comment.
Should we set this to the latest version v1.64.5?
There was a problem hiding this comment.
I just confirmed this. Please refer to etcd-io/raft#268 (comment)
Suggested change
| version: v1.63.4 | |
| version: v1.64.5 |
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
Elbehery
force-pushed
the
20250216-bump-go-linter-1.24
branch
from
ee42474 to
42765f6
Compare
ahrtr
approved these changes
Feb 21, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, Elbehery The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#102 CI failure is due to linter version used.
This PR bumps the go-linter version used in CI
@ivanvc @henrybear327