Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG for version bump to go 1.23.6 #19431

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

joshjms
Copy link
Contributor

@joshjms joshjms commented Feb 17, 2025

Updated the dependencies section in CHANGELOG-3.4.md under v3.4.36 and CHANGELOG-3.5.md under v3.5.19 to compile binaries using go 1.23.6.

Subtask of #19417

…pdate

Signed-off-by: joshjms <joshjms1607@gmail.com>
@k8s-ci-robot
Copy link

Hi @joshjms. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc mentioned this pull request Feb 18, 2025
16 tasks
@ahrtr
Copy link
Member

ahrtr commented Feb 18, 2025

/ok-to-test

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (eb7607b) to head (d86775c).
Report is 6 commits behind head on main.

Additional details and impacted files

see 18 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19431   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files         420      420           
  Lines       35753    35753           
=======================================
+ Hits        24632    24633    +1     
- Misses       9698     9699    +1     
+ Partials     1423     1421    -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7607b...d86775c. Read the comment docs.

@joshjms
Copy link
Contributor Author

joshjms commented Feb 18, 2025

/retest

@ivanvc
Copy link
Member

ivanvc commented Feb 18, 2025

/test pull-etcd-e2e-amd64

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green. Thanks, @joshjms.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, joshjms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit ef65923 into etcd-io:main Feb 19, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants