Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: remove coverage workflow #19424

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Feb 15, 2025

This workflow has already been migrated to the Prow infrastructure.

To have the Codecov bot publish the coverage report from the given pull request, it must be invoked using some additional arguments.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This workflow has already been migrated to the Prow infrastructure.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress github_actions Pull requests that update GitHub Actions code approved labels Feb 15, 2025
@ivanvc
Copy link
Member Author

ivanvc commented Feb 15, 2025

/test all

@ivanvc
Copy link
Member Author

ivanvc commented Feb 15, 2025

/test pull-etcd-coverage-report

1 similar comment
@ivanvc
Copy link
Member Author

ivanvc commented Feb 15, 2025

/test pull-etcd-coverage-report

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (14cf669) to head (1651346).

Current head 1651346 differs from pull request most recent head 5bb5f28

Please upload reports for the commit 5bb5f28 to get more accurate results.

Additional details and impacted files

see 31 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19424      +/-   ##
==========================================
- Coverage   68.95%   68.84%   -0.12%     
==========================================
  Files         420      420              
  Lines       35753    35727      -26     
==========================================
- Hits        24655    24595      -60     
- Misses       9677     9703      +26     
- Partials     1421     1429       +8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14cf669...5bb5f28. Read the comment docs.

Add extra arguments to ensure that CodeCov assumes the upload comes from
a CI environment.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc ivanvc force-pushed the remove-codecov-github-workflow branch from 1651346 to 5bb5f28 Compare February 16, 2025 04:04
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivanvc
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc ivanvc changed the title [WIP] github/workflows: remove coverage workflow github/workflows: remove coverage workflow Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress github_actions Pull requests that update GitHub Actions code size/M
Development

Successfully merging this pull request may close these issues.

2 participants