Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release script prerelease GitHub template release #19418

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Feb 14, 2025

Follow up on #19334:

  • Properly get the minor version from prereleases (i.e., v3.6.0-rc.0v3.6, not v3.6.0-rc). I tested it on my fork, and the linked pages are as expected (note that we still have a broken link in the upgrade guide): https://github.com/ivanvc/etcd/releases/tag/v3.6.0-rc.0
  • Fix a typo in "flag". It said "flat".

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (8c52b41) to head (5c9db9c).
Report is 3 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19418      +/-   ##
==========================================
- Coverage   68.97%   68.91%   -0.07%     
==========================================
  Files         420      420              
  Lines       35753    35753              
==========================================
- Hits        24662    24639      -23     
- Misses       9664     9689      +25     
+ Partials     1427     1425       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c52b41...5c9db9c. Read the comment docs.

@serathius
Copy link
Member

scripts/release.sh:367:11: warning: Declare and assign separately to avoid masking return values. [SC2155]

@ivanvc ivanvc force-pushed the fix-release-script-prerelease-github-template-release branch from 53998b0 to 60af25e Compare February 14, 2025 16:59
@ivanvc
Copy link
Member Author

ivanvc commented Feb 14, 2025

scripts/release.sh:367:11: warning: Declare and assign separately to avoid masking return values. [SC2155]

Done. I pushed and went straight to my bed 🛌 😴 😄

The GitHub release templates had the wrong version minor when there's a
prerelease part in the version (i.e., v3.6.0-rc.0). It cut until the
last dot, leaving a wrong minor version (i.e., v3.6.0-rc).

Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc ivanvc force-pushed the fix-release-script-prerelease-github-template-release branch from 60af25e to 5c9db9c Compare February 14, 2025 17:23
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 14cf669 into etcd-io:main Feb 14, 2025
37 checks passed
@ahrtr
Copy link
Member

ahrtr commented Feb 14, 2025

Do we need to backport this PR to 3.6/3.5/3.4?

@ivanvc
Copy link
Member Author

ivanvc commented Feb 14, 2025

Do we need to backport this PR to 3.6/3.5/3.4?

We need it in 3.6. We can do 3.5 and 3.4 for consistency, but it is not needed.

/cherry-pick release-3.6

@ivanvc ivanvc deleted the fix-release-script-prerelease-github-template-release branch February 14, 2025 20:35
@k8s-infra-cherrypick-robot

@ivanvc: new pull request created: #19420

In response to this:

Do we need to backport this PR to 3.6/3.5/3.4?

We need it in 3.6. We can do 3.5 and 3.4 for consistency, but it is not needed.

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants