-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release script prerelease GitHub template release #19418
Fix release script prerelease GitHub template release #19418
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #19418 +/- ##
==========================================
- Coverage 68.97% 68.91% -0.07%
==========================================
Files 420 420
Lines 35753 35753
==========================================
- Hits 24662 24639 -23
- Misses 9664 9689 +25
+ Partials 1427 1425 -2 Continue to review full report in Codecov by Sentry.
|
|
53998b0
to
60af25e
Compare
Done. I pushed and went straight to my bed 🛌 😴 😄 |
The GitHub release templates had the wrong version minor when there's a prerelease part in the version (i.e., v3.6.0-rc.0). It cut until the last dot, leaving a wrong minor version (i.e., v3.6.0-rc). Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
60af25e
to
5c9db9c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Do we need to backport this PR to 3.6/3.5/3.4? |
We need it in 3.6. We can do 3.5 and 3.4 for consistency, but it is not needed. /cherry-pick release-3.6 |
@ivanvc: new pull request created: #19420 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Follow up on #19334:
v3.6.0-rc.0
→v3.6
, notv3.6.0-rc
). I tested it on my fork, and the linked pages are as expected (note that we still have a broken link in the upgrade guide): https://github.com/ivanvc/etcd/releases/tag/v3.6.0-rc.0Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.