Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate experimental distributed tracing flags to non-experimental flags #19385

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Feb 11, 2025

Fix #19050

Part of #18023

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 97.91667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.94%. Comparing base (1ea4f43) to head (a9b8cba).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/embed/config.go 93.75% 0 Missing and 1 partial ⚠️
server/embed/config_tracing.go 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/config/config.go 80.23% <ø> (ø)
server/embed/etcd.go 76.36% <100.00%> (ø)
server/etcdmain/config.go 75.82% <100.00%> (+1.40%) ⬆️
server/etcdserver/api/v3rpc/grpc.go 95.12% <100.00%> (ø)
server/embed/config.go 79.94% <93.75%> (+0.21%) ⬆️
server/embed/config_tracing.go 82.60% <87.50%> (ø)

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19385      +/-   ##
==========================================
+ Coverage   68.91%   68.94%   +0.02%     
==========================================
  Files         420      420              
  Lines       35739    35756      +17     
==========================================
+ Hits        24631    24652      +21     
+ Misses       9684     9680       -4     
  Partials     1424     1424              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea4f43...a9b8cba. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Feb 11, 2025

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit f197f44 into etcd-io:main Feb 11, 2025
37 checks passed
@ahrtr
Copy link
Member Author

ahrtr commented Feb 11, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ahrtr: new pull request created: #19387

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

migrate --experimental-enable-distributed-tracing flag to feature gate
4 participants