-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate experimental-compaction-sleep-interval flag to compaction-sleep interval #19351
migrate experimental-compaction-sleep-interval flag to compaction-sleep interval #19351
Conversation
Hi @ajaysundark. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 23 files with indirect coverage changes @@ Coverage Diff @@
## main #19351 +/- ##
==========================================
+ Coverage 68.86% 69.04% +0.18%
==========================================
Files 420 420
Lines 35720 35723 +3
==========================================
+ Hits 24597 24664 +67
+ Misses 9701 9643 -58
+ Partials 1422 1416 -6 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
Please rebase this PR. thx |
…ep-interval Signed-off-by: Ajay Sundar Karuppasamy <ajaysundar@google.com>
292d01e
to
299bca3
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ajaysundark, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ajaysundark, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Migrate
experimental-compaction-sleep-interval
flag tocompaction-sleep-interval
Sub task from #19141