Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate experimental-compaction-sleep-interval flag to compaction-sleep interval #19351

Conversation

ajaysundark
Copy link
Contributor

@ajaysundark ajaysundark commented Feb 6, 2025

Migrate experimental-compaction-sleep-interval flag to compaction-sleep-interval

Sub task from #19141

@k8s-ci-robot
Copy link

Hi @ajaysundark. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ajaysundark
Copy link
Contributor Author

/cc @siyuanfoundation

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.04%. Comparing base (299bca3) to head (e5b39f8).
Report is 4 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config.go 79.78% <100.00%> (+0.03%) ⬆️
server/embed/etcd.go 76.45% <100.00%> (ø)
server/etcdmain/config.go 74.11% <100.00%> (+0.30%) ⬆️

... and 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19351      +/-   ##
==========================================
+ Coverage   68.86%   69.04%   +0.18%     
==========================================
  Files         420      420              
  Lines       35720    35723       +3     
==========================================
+ Hits        24597    24664      +67     
+ Misses       9701     9643      -58     
+ Partials     1422     1416       -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299bca3...e5b39f8. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Feb 6, 2025

/ok-to-test

@ahrtr
Copy link
Member

ahrtr commented Feb 6, 2025

Please rebase this PR. thx

…ep-interval

Signed-off-by: Ajay Sundar Karuppasamy <ajaysundar@google.com>
@ajaysundark ajaysundark closed this Feb 6, 2025
@ajaysundark ajaysundark force-pushed the migrate-experimental-compaction-sleep-interval branch from 292d01e to 299bca3 Compare February 6, 2025 18:56
@ajaysundark ajaysundark reopened this Feb 6, 2025
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ajaysundark, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ajaysundark, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 8e0ea34 into etcd-io:main Feb 6, 2025
49 checks passed
@ajaysundark ajaysundark deleted the migrate-experimental-compaction-sleep-interval branch February 11, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants