Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format all prometheus metrics to ensure nice indent #19301

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 29, 2025

@mmorel-35 do you know is there a linter to enforce the nice indent for metrics definition?

cc @fuweid @ivanvc @jmhbnz @dims @serathius

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@k8s-ci-robot
Copy link

@ahrtr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-release-tests 614640f link false /test pull-etcd-release-tests

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (35d20d1) to head (614640f).
Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/auth/metrics.go 87.50% <ø> (ø)
server/etcdserver/api/etcdhttp/health.go 91.46% <ø> (ø)
server/etcdserver/api/membership/metrics.go 100.00% <ø> (ø)
server/etcdserver/api/rafthttp/metrics.go 100.00% <ø> (ø)
server/etcdserver/api/v2store/metrics.go 92.00% <ø> (ø)
server/etcdserver/api/v3rpc/metrics.go 100.00% <ø> (ø)
server/etcdserver/apply/metrics.go 100.00% <ø> (ø)
server/etcdserver/metrics.go 80.43% <ø> (ø)
server/etcdserver/txn/metrics.go 100.00% <ø> (ø)
server/lease/metrics.go 100.00% <ø> (ø)
... and 1 more

... and 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19301      +/-   ##
==========================================
- Coverage   68.84%   68.83%   -0.02%     
==========================================
  Files         420      420              
  Lines       35689    35689              
==========================================
- Hits        24570    24565       -5     
- Misses       9693     9694       +1     
- Partials     1426     1430       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d20d1...614640f. Read the comment docs.

@ahrtr ahrtr merged commit 6ed344f into etcd-io:main Jan 29, 2025
35 of 36 checks passed
@ahrtr ahrtr deleted the metrics_format_20250129 branch January 29, 2025 14:35
@mmorel-35
Copy link
Contributor

@ahrtr
Copy link
Member Author

ahrtr commented Jan 29, 2025

Have you seen https://golangci-lint.run/usage/linters/#promlinter ?

Can the linter resolve all the format "issues" updated in this PR?

@mmorel-35
Copy link
Contributor

I have no clue but that's the only one I saw that concerns prometheus, Maybe they are open to adress your issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants