-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format all prometheus metrics to ensure nice indent #19301
Conversation
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 23 files with indirect coverage changes @@ Coverage Diff @@
## main #19301 +/- ##
==========================================
- Coverage 68.84% 68.83% -0.02%
==========================================
Files 420 420
Lines 35689 35689
==========================================
- Hits 24570 24565 -5
- Misses 9693 9694 +1
- Partials 1426 1430 +4 Continue to review full report in Codecov by Sentry.
|
Have you seen https://golangci-lint.run/usage/linters/#promlinter ? |
Can the linter resolve all the format "issues" updated in this PR? |
I have no clue but that's the only one I saw that concerns prometheus, Maybe they are open to adress your issues |
@mmorel-35 do you know is there a linter to enforce the nice indent for metrics definition?
cc @fuweid @ivanvc @jmhbnz @dims @serathius