Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable gofumpt instead of gofmt linter globally #18956

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 27, 2024

Description

enables and fixes gofumpt linter issues globally

Closes #18955

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (8f91eb1) to head (f75f402).
Report is 15 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
pkg/expect/expect.go 79.12% <ø> (ø)
pkg/netutil/routes_linux.go 44.62% <ø> (ø)
pkg/traceutil/trace.go 98.09% <100.00%> (+0.01%) ⬆️

... and 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18956      +/-   ##
==========================================
- Coverage   68.80%   68.78%   -0.03%     
==========================================
  Files         420      420              
  Lines       35575    35576       +1     
==========================================
- Hits        24479    24470       -9     
- Misses       9670     9682      +12     
+ Partials     1426     1424       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f91eb1...f75f402. Read the comment docs.

@mmorel-35
Copy link
Contributor Author

/assign @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Nov 28, 2024

/ok-to-test

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 changed the title fix: enable gofumpt instead of gofmt linter in pkg fix: enable gofumpt instead of gofmt linter globally Nov 29, 2024
@mmorel-35 mmorel-35 marked this pull request as ready for review November 29, 2024 10:07
@ahrtr ahrtr requested review from ivanvc, fuweid and jmhbnz November 29, 2024 10:08
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @mmorel-35

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit e476f72 into etcd-io:main Nov 30, 2024
33 of 34 checks passed
@mmorel-35 mmorel-35 deleted the gofumpt/pkg branch November 30, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Enable gofumpt linter
4 participants