build(deps): bump github.com/golangci/golangci-lint from 1.59.1 to 1.60.3 in /tools/mod #18504
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.59.1 to 1.60.3. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.59.1...v1.60.3) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 17 files with indirect coverage changes @@ Coverage Diff @@
## main #18504 +/- ##
==========================================
- Coverage 68.87% 68.85% -0.02%
==========================================
Files 420 420
Lines 35489 35489
==========================================
- Hits 24444 24437 -7
- Misses 9617 9629 +12
+ Partials 1428 1423 -5 Continue to review full report in Codecov by Sentry.
|
|
/ok-to-test |
|
@dependabot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Could anyone resolve the workflow failures? Thanks |
I am on it. |
@henrybear327, you're doing it as part of the weekly dependency bump, right? |
|
Before |
|
After |
|
Thanks, @henrybear327. Check https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/etcd-io_etcd/18504/pull-etcd-verify/1828149502016491520. I think you'll need to address that along with the dependency bump (what Benjamin was referring to) |
|
Oh, thanks @ivanvc for the pointer! I will put up the PR as a draft first, then I will start to address it! :) |
Reference: - etcd-io#18504 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Addressed |
|
Looks like github.com/golangci/golangci-lint is up-to-date now, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/go_modules/tools/mod/github.com/golangci/golangci-lint-1.60.3
branch
Reference: - etcd-io#18504 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Reference: - etcd-io#18504 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Bumps github.com/golangci/golangci-lint from 1.59.1 to 1.60.3.
Release notes
Sourced from github.com/golangci/golangci-lint's releases.
... (truncated)
Changelog
Sourced from github.com/golangci/golangci-lint's changelog.
... (truncated)
Commits
c2e095cbuild(deps): bump github.com/securego/gosec/v2 from 81cda2f91fbe to ab3f6c1c8...f0c1904feat: check that Go version use to build is greater or equals to the Go versi...2f53f2cdocs: update documentation (#4931)1bdd38bdocs: update documentation assets (#4930)561049ddocs: update GitHub Action assets (#4929)f338f3ebuild(deps): bump github.com/securego/gosec/v2 from 5f0084eb01a9 to 81cda2f91...741df1fdev: fix GO_VERSION in post release workflow (#4926)87dd8feexportloopref: deprecation (#4916)af298e1chore: update gofmt (#4923)132d81cbuild(deps): bump github.com/tomarrell/wrapcheck/v2 from 2.8.3 to 2.9.0 (#4921)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)