-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts/release: shallow clone repository #18095
scripts/release: shallow clone repository #18095
Conversation
Signed-off-by: Ivan Valdes <ivan@vald.es>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ivanvc
@jmhbnz, should we backport this into 3.4 too? |
Personally I think yes to try and keep release process consistent and given we believe this to be a low risk improvement. Though this decision would be to @ahrtr as overall release manager for 3.4. Also ref: #17677 (comment) |
@ivanvc please feel free to deliver a PR to 3.4. thx |
Backport of commit 4881e53 / pull request etcd-io#18095. Signed-off-by: Ivan Valdes <ivan@vald.es>
Backport of commit 4881e53 / pull request etcd-io#18095. Signed-off-by: Ivan Valdes <ivan@vald.es>
Backport of commit 4881e53 / pull request etcd-io#18095. Signed-off-by: Ivan Valdes <ivan@vald.es>
Minor improvement that was identified when releasing v3.5.14.
Related to #18013.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.