From a3c072c3e87a553f611ac9511b9f94ff3a43c002 Mon Sep 17 00:00:00 2001 From: Chun-Hung Tseng Date: Tue, 21 Jan 2025 21:28:41 +0000 Subject: [PATCH] Add missing error checking after calling DowngradeUpgradeMembers Signed-off-by: Chun-Hung Tseng Signed-off-by: Chun-Hung Tseng --- tests/e2e/cluster_downgrade_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/e2e/cluster_downgrade_test.go b/tests/e2e/cluster_downgrade_test.go index 5779e0547d6..f71cae5b535 100644 --- a/tests/e2e/cluster_downgrade_test.go +++ b/tests/e2e/cluster_downgrade_test.go @@ -144,7 +144,8 @@ func testDowngradeUpgrade(t *testing.T, clusterSize int, triggerSnapshot bool, t } t.Logf("Starting downgrade process to %q", lastVersionStr) - e2e.DowngradeUpgradeMembers(t, nil, epc, len(epc.Procs), currentVersion, lastClusterVersion) + err = e2e.DowngradeUpgradeMembers(t, nil, epc, len(epc.Procs), currentVersion, lastClusterVersion) + require.NoError(t, err) e2e.AssertProcessLogs(t, leader(t, epc), "the cluster has been downgraded") t.Log("Downgrade complete") @@ -170,7 +171,8 @@ func testDowngradeUpgrade(t *testing.T, clusterSize int, triggerSnapshot bool, t beforeMembers, beforeKV = getMembersAndKeys(t, cc) t.Logf("Starting upgrade process to %q", currentVersionStr) - e2e.DowngradeUpgradeMembers(t, nil, epc, len(epc.Procs), lastClusterVersion, currentVersion) + err = e2e.DowngradeUpgradeMembers(t, nil, epc, len(epc.Procs), lastClusterVersion, currentVersion) + require.NoError(t, err) t.Log("Upgrade complete") afterMembers, afterKV = getMembersAndKeys(t, cc) @@ -278,7 +280,6 @@ func generateIdenticalVersions(clusterSize int, currentVersion string) []*versio Server: currentVersion, Storage: currentVersion, } - } return ret