From 668834b7dfffb9b0f8f743b62f4cb3429127bd2a Mon Sep 17 00:00:00 2001 From: Marek Siarkowicz Date: Wed, 23 Oct 2024 22:59:55 +0200 Subject: [PATCH] Allow duplicated put requests Signed-off-by: Marek Siarkowicz --- tests/robustness/validate/validate.go | 36 +-------------------------- 1 file changed, 1 insertion(+), 35 deletions(-) diff --git a/tests/robustness/validate/validate.go b/tests/robustness/validate/validate.go index e119ea4c574..5918ec0df83 100644 --- a/tests/robustness/validate/validate.go +++ b/tests/robustness/validate/validate.go @@ -59,11 +59,7 @@ type Config struct { } func checkValidationAssumptions(reports []report.ClientReport, persistedRequests []model.EtcdRequest) error { - err := validatePutOperationUnique(reports) - if err != nil { - return err - } - err = validateEmptyDatabaseAtStart(reports) + err := validateEmptyDatabaseAtStart(reports) if err != nil { return err } @@ -79,36 +75,6 @@ func checkValidationAssumptions(reports []report.ClientReport, persistedRequests return nil } -func validatePutOperationUnique(reports []report.ClientReport) error { - type KV struct { - Key string - Value model.ValueOrHash - } - putValue := map[KV]struct{}{} - for _, r := range reports { - for _, op := range r.KeyValue { - request := op.Input.(model.EtcdRequest) - if request.Type != model.Txn { - continue - } - for _, op := range append(request.Txn.OperationsOnSuccess, request.Txn.OperationsOnFailure...) { - if op.Type != model.PutOperation { - continue - } - kv := KV{ - Key: op.Put.Key, - Value: op.Put.Value, - } - if _, ok := putValue[kv]; ok { - return fmt.Errorf("non unique put %v, required to patch operation history", kv) - } - putValue[kv] = struct{}{} - } - } - } - return nil -} - func validateEmptyDatabaseAtStart(reports []report.ClientReport) error { for _, r := range reports { for _, op := range r.KeyValue {