Remove unnecessary make command to install tools in e2e tests #72
Conversation
The make kustomize and controller-gen targets are prerequisites of the targets later called in the e2e tests, so there's no need to manually trigger them. Signed-off-by: Ivan Valdes <ivan@vald.es>
| // gen manifest files | ||
| log.Println("Generate manifests...") | ||
| cmd = exec.Command("make", "manifests") | ||
| cmd := exec.Command("make", "manifests") |
There was a problem hiding this comment.
It seems that even `make manifests" isn't needed. Feel free to raise a new PR to remove & test it. thx
Line 134 in 4442c81
There was a problem hiding this comment.
I see. manifests is a prereq from test-e2e. So, we could also call docker-build by setting it as a prereq for test-e2e. I'll open a pull request with this change, too.
There was a problem hiding this comment.
Ah, nevermind. It is a pre-requisite for install, as you mentioned. It doesn't make sense to have it as prereq for test-e2e, because if the tests are run with go test, it won't have the manifests. It makes more sense to remove it from test-e2e.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ivanvc
deleted the
remove-unnecessary-make-command-installs-in-e2e-tests
branch
The make
kustomizeandcontroller-gentargets are prerequisites of the targets later called in the e2e tests (controller-genfrommanifests, andkustomizefrominstall), so there's no need to trigger them manually.