Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to go1.22 #690

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Migrate to go1.22 #690

merged 1 commit into from
Mar 6, 2024

Conversation

dusk125
Copy link
Contributor

@dusk125 dusk125 commented Feb 7, 2024

Part of etcd-io/etcd#17348.
bbolt tests successfully locally.

@dusk125
Copy link
Contributor Author

dusk125 commented Feb 8, 2024

@ahrtr @serathius ptal

@serathius
Copy link
Member

/ok-to-test

@ahrtr
Copy link
Member

ahrtr commented Feb 8, 2024

Failed on windows

find: paths must precede expression: `bolt_386.go'
find: possible unquoted pattern after predicate `-name'?
hashmap freelist test
BBOLT_VERIFY=all TEST_FREELIST_TYPE=hashmap go test -v -race=false -cpu=4  -timeout 30m
go.etcd.io/bbolt/errors: cannot compile Go 1.22 code
FAIL	go.etcd.io/bbolt [build failed]
make: *** [Makefile:45: test] Error 1
Error: Process completed with exit code 2.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the failure on Windows

@ahrtr
Copy link
Member

ahrtr commented Mar 6, 2024

@dusk125 @jmhbnz could you take a look at the workflow failure? It looks like somehow the go version/env hasn't been setup successfully on Windows.

Signed-off-by: Allen Ray <alray@redhat.com>
@ahrtr ahrtr merged commit 3fa18ae into etcd-io:main Mar 6, 2024
16 checks passed
@dusk125 dusk125 deleted the upgrade-go1.22 branch March 6, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants