tests/robustness: switch to kill if no panic after 10sec #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @ahrtr |
ahrtr
reviewed
Jan 4, 2024
Comment on lines
144
to
145
| t.Log("bbolt should stop with panic in 10 seconds") | ||
| t.Log("switch to kill") |
There was a problem hiding this comment.
Probably we should fail the test in such case, because it doesn't run as expected.
Suggested change
| t.Log("bbolt should stop with panic in 10 seconds") | |
| t.Log("switch to kill") | |
| t.Log("bbolt is supposed to be already stopped, but actually not yet; forcibly kill it") |
There was a problem hiding this comment.
Hard to tell. If that storage is too fast, before we invoke failpoint, db size has been resized and the size is large enough.
If file doesn't grow in 10 sec, bbolt won't trigger the following errors: * lackOfDiskSpace * mapError * resizeFileError * unmapError We should switch to kill instead of waiting for panic. In order to trigger these errors, we should increase value size to 512. Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
force-pushed
the
fuweid/fix-powerfailure
branch
from
5cf6e34 to
49eb212
Compare
ahrtr
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If file doesn't grow in 10 sec, bbolt won't trigger the following errors:
We should switch to kill instead of waiting for panic. In order to trigger these errors, we should increase value size to 512.