Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the implementation of check #651

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Refactor the implementation of check #651

merged 1 commit into from
Dec 29, 2023

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 27, 2023

Link to #580

The first step to enhance the check method.

  • rename some methods to make them clearer
  • move common source code into a common function, so that they can be reused.

@ahrtr
refactor the implementation of check
23c97d5 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr
Copy link
Member Author

ahrtr commented Dec 28, 2023

cc @fuweid @tjungblu

@ahrtr ahrtr mentioned this pull request Dec 28, 2023
Closed
fuweid
fuweid approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit de6c42b into etcd-io:main Dec 29, 2023
14 checks passed
@Elbehery Elbehery mentioned this pull request Jan 1, 2024
Merged
@ahrtr ahrtr deleted the renaming_20231227 branch June 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrtr @fuweid