Add binary-safe alternatives for eval #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only externally accessible commands for EVAL and friends take Seq[String] for keys and arguments. String can only contain valid UTF-8 sequences, which makes it impossible to send arbitrary binary data to a Lua script, for example to do a compare-and-set of compressed data.
This exposes a new evalBinary method and related equivalents that expose the ability for an application to provide its own ByteStringSerializer instances for arguments to scripts. Note these can't easily be written as simple overloads because the erased type of the arguments (Seq[_]) would be identical to the existing Seq[String] methods.