doc: Fix intersection of shape defaults #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
force-pushed
the
jshearer/fix_default_shape_intersection
branch
from
1499d02 to
4a978b4
Compare
We weren't correctly narrowing the default of intersected shapes. For example, if we intersected one shape like
```json
{
"type": ["string", "null"],
"default": "null"
}
```
with another shape like
```json
{
"type": "string"
}
```
We'd end up with a shape of
```json
{
"type": "string",
"default": null
}
```
Which isn't correct, as when we try to actually emit a document for this shape that's missing the field
in question and provide its default value of null, that will subsequently fail to validate against the schema.
Fixes #1944
jshearer
force-pushed
the
jshearer/fix_default_shape_intersection
branch
from
4a978b4 to
819fb98
Compare
jshearer
changed the base branch from
master
to
jshearer/dekaf_testing_and_fix_default_intersection
jshearer
merged commit f6cc7b1
into
jshearer/dekaf_testing_and_fix_default_intersection
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We weren't correctly narrowing the default of intersected shapes. For example, if we intersected one shape like
{ "type": ["string", "null"], "default": "null" }with another shape like
{ "type": "string" }We'd end up with a shape of
{ "type": "string", "default": null }Which isn't correct, as when we try to actually emit a document for this shape that's missing the field in question and provide its default value of null, that will subsequently fail to validate against the schema.
Also adds a test to confirm Dekaf's proper handling of schemas like this, which is why this branch is ontop of that one.
Fixes #1944
This change is