Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/feature_flags: Trim whitespace #2470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

willdonnelly
Copy link
Member

@willdonnelly willdonnelly commented Feb 28, 2025

Description:

Makes it so a setting like do_foo, do_bar parses the same as do_foo,do_bar.

Without this fix it instead parses the second one as a flag setting " do_bar" which is clearly very distinct from the intended "do_bar" flag.


This change is Reviewable

Makes it so a setting like `do_foo, do_bar` parses the same as
`do_foo,do_bar`. Without this fix it instead parses as a flag
setting `" do_bar"` which is clearly very distinct from the
`"do_bar"` flag.
@willdonnelly willdonnelly added the change:unplanned Unplanned change, useful for things like doc updates label Feb 28, 2025
@willdonnelly willdonnelly requested a review from a team February 28, 2025 23:06
Copy link
Member

@Alex-Bair Alex-Bair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants